fix: pass along skipConditions when filtering out infinitelyNarrowPatches#117
Merged
fix: pass along skipConditions when filtering out infinitelyNarrowPatches#117
Conversation
There was a problem hiding this comment.
PR Overview
This PR addresses a bug by ensuring that skipConditions are passed along when filtering out infinitely narrow patches in the patch chain.
- Updates the constructor call for TimeRangePatchChain to include skipConditions
- Ensures consistency in patch processing when skip conditions apply
Reviewed Changes
| File | Description |
|---|---|
| ChronoJsonDiffPatch/ChronoJsonDiffPatch/TimeRangePatchChain.cs | Passes _skipConditions to the TimeRangePatchChain constructor when filtering out infinitely narrow patches |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
ChronoJsonDiffPatch/ChronoJsonDiffPatch/TimeRangePatchChain.cs:327
- Ensure that passing _skipConditions into the TimeRangePatchChain constructor does not inadvertently alter the behavior of patch filtering. Verify that _skipConditions is properly initialized and tested in this context to maintain consistent patch application.
GetAll().Where(p => !p.Equals(patchToBeAdded)),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.