fix: use relative import to fix Docker ModuleNotFoundError#342
Merged
fix: use relative import to fix Docker ModuleNotFoundError#342
Conversation
The Dockerfile runs `python ebd_toolchain/main.py` directly, which adds `/app/ebd_toolchain/` to sys.path but NOT `/app/`. This means absolute intra-package imports like `from ebd_toolchain.ahb_pruefi import ...` fail with: ModuleNotFoundError: No module named 'ebd_toolchain' Fix: use relative import (`from .ahb_pruefi import ...`) which works regardless of how the script is invoked. Also adds a CI guard test that scans all .py files in the package for absolute intra-package imports and fails if any are found. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reviewer found that bare `import ebd_toolchain.foo` would slip through because ast.Import stores names in node.names, not node.module. Also switched glob to rglob to catch future sub-packages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleNotFoundError: No module named 'ebd_toolchain'when running in Dockerfrom ebd_toolchain.ahb_pruefi import ...tofrom .ahb_pruefi import ...Root cause
The Dockerfile runs
python ebd_toolchain/main.pydirectly. Python adds the script's directory (/app/ebd_toolchain/) tosys.path, not its parent (/app/). Soimport ebd_toolchainfails because/app/is not on the path.Prevention
New test
test_no_absolute_intra_imports.pyscans all.pyfiles in the package usingastand fails if any usefrom ebd_toolchain.* import ...instead of relative imports.Test plan
🤖 Generated with Claude Code