Wrong audit failure for versioned alias

[fxcoudert]

The audit for versioned aliases is misbehaving, diagnosing an inexistent problem with the imagemagick formula:

$ brew audit --strict imagemagick
imagemagick:
  * Formula has other versions so create a versioned alias:
      cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Aliases
      ln -s ../Formula/imagemagick.rb imagemagick@7
  * Formula has invalid versioned aliases:
      imagemagick@7
Error: 2 problems in 1 formula

The audit is invalid, as the versioned alias already exists, and rightly so.

(Possibly related to #2644 ? poke @JCount @MikeMcQuaid)

[zmwangx]

#2644 is adding qualification to core formulae. Something like

diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index 3c42b45a1d..c71a640991 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -323,7 +323,7 @@ class FormulaAuditor
       end
       valid_alias_names = [alias_name_major, alias_name_major_minor]
 
-      if formula.tap
+      if formula.tap && formula.tap != 'homebrew/core'
         valid_alias_names.map! { |a| "#{formula.tap}/#{a}" }
       end
 

should fix it.

[JCount]

Whoops, thanks for the catch @zmwangx, @fxcoudert! 😄

The patch fixed this issue in non-core taps, but ended up creating it in core as a unintended consequence. 😅