Skip to content

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Dec 9, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

When reading a building a formula from a keg (rather than e.g. from name) then the deprecation options were not remapped correctly as they are only done in Tab.for_formula and not Tab.for_keg. Ensure that after we’ve created the formula that the used_options are remapped
correctly.

Fixes Homebrew/homebrew-core#7630.

When reading a building a formula from a keg (rather than e.g. from
name) then the deprecation options were not remapped correctly as they
are only done in `Tab.for_formula` and not `Tab.for_keg`. Ensure that
after we’ve created the formula that the `used_options` are remapped
correctly.
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Dec 9, 2016
@MikeMcQuaid MikeMcQuaid requested a review from ilovezfs December 10, 2016 13:05
@MikeMcQuaid MikeMcQuaid merged commit a566540 into Homebrew:master Dec 10, 2016
@MikeMcQuaid MikeMcQuaid deleted the formulary-remap-options branch December 10, 2016 13:50
@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Dec 10, 2016
@ilovezfs
Copy link
Contributor

Just to get this on the PR and not just Slack, it seems this has caused the bug discovered in Homebrew/homebrew-core#4258 and fixed in #835 to return.

iMac-TMP:Homebrew joe$ brew install --only-dependencies codequery
==> Installing dependencies for codequery: sip
==> Installing codequery dependency: sip
==> Downloading https://homebrew.bintray.com/bottles/sip-4.18.1.el_capitan.bottle.tar.gz
Already downloaded: /Users/joe/Library/Caches/Homebrew/sip-4.18.1.el_capitan.bottle.tar.gz
==> Pouring sip-4.18.1.el_capitan.bottle.tar.gz
==> Using the sandbox
==> Caveats
The sip-dir for Python is /usr/local/share/sip.
==> Summary
🍺  /usr/local/Cellar/sip/4.18.1: 11 files, 903.7K
iMac-TMP:Homebrew joe$ 

The expected behavior is that it should build sip --with-python3 as specified by qscintilla2, which is a dependency of codequery.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Dec 10, 2016
5 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants