diagnostic: check for bad tap files.

[MikeMcQuaid]

Check for Ruby files in taps that are outside of the detected Formula directory for a tap but inside one of the other potential directories.

This usually indicates a formula has been added in the wrong directory in a tap and is used to fail CI in this case.

[MikeMcQuaid]

@ilovezfs Any thoughts on this?

[ilovezfs]

Won't this break

bash-4.4$ find homebrew-emacs|grep rb|grep -v Formula|grep -v '\.git'
homebrew-emacs/cmd/brew-emacs.rb
homebrew-emacs/Homebrew/emacs.rb
homebrew-emacs/Homebrew/emacs_formula.rb
bash-4.4$ find homebrew-php|grep rb|grep -v Formula|grep -v '\.git'
homebrew-php/Abstract/abstract-php-extension.rb
homebrew-php/Abstract/abstract-php-phar.rb
homebrew-php/Abstract/abstract-php-version.rb
homebrew-php/Abstract/abstract-php.rb
homebrew-php/language/php.rb
homebrew-php/Requirements/composer-requirement.rb
homebrew-php/Requirements/homebrew-php-requirement.rb
homebrew-php/Requirements/phar-building-requirement.rb
homebrew-php/Requirements/phar-requirement.rb
homebrew-php/Requirements/php-meta-requirement.rb

[MikeMcQuaid]

@ilovezfs I will test, thanks. If it does: suggestions for a better test? Check for things with < Formula?

[MikeMcQuaid]

Both work fine.