Skip to content

Conversation

@apjanke
Copy link
Contributor

@apjanke apjanke commented Dec 20, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes #1692. See it for details.

Currently, the --all, --installed, and --tree modes ignore the --full-name option. This makes them respect it.

I haven't added new tests for this because I think that would require having a non-default tap tapped. The tap_test.rb file has code for setting up a tap, and that could be reused here with some refactoring, but that seems like overkill for this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can do .map(&method(:dep_display_name)).uniq here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a .join is a bit more readable here but no strong preference.

@MikeMcQuaid
Copy link
Member

I haven't added new tests for this because I think that would require having a non-default tap tapped. The tap_test.rb file has code for setting up a tap, and that could be reused here with some refactoring, but that seems like overkill for this change.

Seems fine 👍

@apjanke apjanke merged commit 6648ff1 into Homebrew:master Dec 28, 2016
@apjanke apjanke removed the in progress Maintainers are working on this label Dec 28, 2016
@apjanke
Copy link
Contributor Author

apjanke commented Dec 28, 2016

Amended to address code comments and merged.

@apjanke apjanke deleted the deps-all-full-name branch December 28, 2016 05:05
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants