Skip to content

Conversation

@vladshablinsky
Copy link
Contributor

Fixes #1718

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label Dec 26, 2016
@MikeMcQuaid
Copy link
Member

Thanks @vladshablinsky for the fix and @jasonkarns for the report (and apologies for overestimating the complexity and edge-cases here).

@MikeMcQuaid MikeMcQuaid merged commit 85f62af into Homebrew:master Dec 29, 2016
@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label Dec 29, 2016
@jasonkarns
Copy link
Contributor

Thanks @vladshablinsky!! And no worries @MikeMcQuaid. I don't begrudge your maintainership (and thank you!)

@vladshablinsky vladshablinsky deleted the rb_in_name branch December 29, 2016 21:46
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants