update-report: handle homebrew/versions imports. #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilovezfs
approved these changes
Jan 2, 2017
Contributor
|
I am glad I thought to mention the weird migration issues I was having. Good work conjuring a fix so rapidly! 😄 |
Member
Author
|
@JCount My pleasure. An issue in future would be even better, though! |
Imports from homebrew/versions are migrated from that tap and then renamed immediately when they hit homebrew/core. This did not trigger our previous rename detection so address these to improve the output and handle migration correctly.
Contributor
|
I didn't even realize the implications of what I had run across, however, but if I had, I certainly would have properly opened an issue. |
Member
Author
|
Cool. No worries just a general comment that your contributions have been consistently high-quality enough that an issue from you would be high-signal. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports from homebrew/versions are migrated from that tap and then renamed immediately when they hit homebrew/core. This did not trigger
our previous rename detection so address these to improve the output and handle migration correctly.