audit: don't allow universal for new formulae. #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're frowning on these now so may as well turn that into code.
ilovezfs
approved these changes
Jan 15, 2017
This was referenced Jan 15, 2017
bfontaine
reviewed
Jan 17, 2017
| next unless @strict | ||
|
|
||
| if o.name == "universal" | ||
| problem "macOS has been 64-bit only since 10.6 so universal options are deprecated." |
Contributor
There was a problem hiding this comment.
Shouldn’t that use an hyphen (64-bit-only)?
Member
Author
There was a problem hiding this comment.
I think it's fine either way.
Contributor
There was a problem hiding this comment.
You could do '64-bit–only' (first a normal hyphen/hyphen-minus, then an en dash,) per section 1.2.1.3 of Wikipedia's article on dashes, but, as noted there near the bottom, that can be somewhat controversial and should only be used to disambiguate when necessary. My gut feeling says that said disambiguation would increase readability, even if only slightly, here, though maybe I'm just hungry…; in any case, it's your guys's call to make, and probably in a future PR, as well, as you closed this one. Feel free to ignore my nit-picking if you wish.
4 tasks
ilovezfs
referenced
this pull request
in Homebrew/homebrew-core
Feb 17, 2017
Closes #9928. Signed-off-by: Tomasz Pajor <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're frowning on these now so may as well turn that into code.
CC @ilovezfs who inspired this.