uses: fix recursive requirement resolution #1862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Homebrew#1848 by sharing recursive dependency resolution between dependencies and requirements. Coincidentally, this also fixes the errors introduced by Homebrew#1784 that necessitated it being reverted in Homebrew#1797.
alyssais
added a commit
to alyssais/brew
that referenced
this pull request
Jan 16, 2017
This is a temporary measure until: - Homebrew#1862 is merged - I can a test on `brew uses` against every formula in the official taps to verify that exceptions are no longer raised.
Member
|
This seems reasonable, thanks 👍 Can you provide some test cases for verifying this? |
Member
|
Sorry, manual test cases to run |
Contributor
Author
Sure. Here's my example from #1848. brew tap homebrew/science
brew uses --recursive --include-optional gccCurrently, this doesn't include homebrew/science/dlib. With this change, it will. Another example: brew tap homebrew/science
brew untap homebrew/apache
brew uses --recursive adamPreviously, this would raise an exception. Now it doesn't. You can verify whether an exception is raised by adding a |
Member
|
Tested, worked, nice work again @alyssais! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Rather than calling
Formula#recursive_requirements, which doesn't allow the block passed toFormula#recursive_dependenciesto be overridden, and thus causesTapFormulaUnavailableErrors, we can use the list of dependencies that were just worked out and check all of those (plus the root formula) for dependencies.This also fixes #1776, because
Formula#recursive_dependentsby default (as called inFormula#recursive_requirements) prunes all optional dependencies — with no way for the caller to override this.