Skip to content

Conversation

@hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Sep 30, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

closes #20750

@hyuraku hyuraku force-pushed the rewrite-which-formula-in-bash branch from 8617d86 to c9f67d9 Compare September 30, 2025 13:46
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Might be worth looking at other shell commands to better match the style.

Are there any additions needed for brew.sh?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hyuraku!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2025
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2025
@p-linnane p-linnane added this pull request to the merge queue Oct 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 1, 2025
@p-linnane
Copy link
Member

Actions is having a hard time today.

@p-linnane p-linnane added this pull request to the merge queue Oct 1, 2025
Merged via the queue into Homebrew:main with commit 710d508 Oct 1, 2025
38 checks passed
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hyuraku!

@hyuraku hyuraku deleted the rewrite-which-formula-in-bash branch October 8, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite brew which-formula in bash

4 participants