-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
brew release should run an actual release workflow
#20808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MikeMcQuaid
merged 2 commits into
main
from
copilot/fix-1fb694c3-47b8-447f-808e-81504dfe1f6c
Oct 13, 2025
Merged
brew release should run an actual release workflow
#20808
MikeMcQuaid
merged 2 commits into
main
from
copilot/fix-1fb694c3-47b8-447f-808e-81504dfe1f6c
Oct 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@copilot try again |
Contributor
Author
Implemented the workflow-based release process. The key changes:
This enables immutable releases by ensuring the package is attached before publication. Commit: bc517ab |
Copilot
AI
changed the title
[WIP]
Oct 2, 2025
brew release should run an actual release workflowbrew release should run an actual release workflow
Copilot finished work on behalf of
MikeMcQuaid
October 2, 2025 18:38
MikeMcQuaid
reviewed
Oct 6, 2025
MikeMcQuaid
reviewed
Oct 7, 2025
Member
|
@copilot fix this CI failure: |
Contributor
Author
... Fixed the Sorbet type checking errors:
Commit: will be in next push |
Copilot finished work on behalf of
MikeMcQuaid
October 8, 2025 08:14
60ef249 to
849f7a1
Compare
849f7a1 to
3dc7c52
Compare
Co-authored-by: MikeMcQuaid <[email protected]>
3dc7c52 to
c3a557e
Compare
MikeMcQuaid
approved these changes
Oct 13, 2025
p-linnane
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew releasecommand and workflow structureworkflow_dispatchtrigger topkg-installer.ymlworkflowrelease: publishedtrigger from workflow--forceflag tobrew releasefor dry-run by defaultImplementation Details
Tag Creation Timing
The tag and draft release are now created in the upload job, AFTER the package has been built and notarized. This ensures the tag only exists once the workflow has completed successfully.
Dry-Run by Default
Without
--force,brew releasenow just shows what release notes would be generated. With--force, it triggers the workflow.Removed Release Trigger
The workflow no longer triggers on
release: publishedevents since the workflow now handles everything.Type Safety Fixes
workflow_run_urlvariable:T.let(nil, T.nilable(String))_efor exception variable in rescue block inside loop to avoid Sorbet scoping issuesFlow:
brew release(without --force) shows release notesbrew release --forcetriggers workflowOriginal prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.