Skip to content

Conversation

@MikeMcQuaid
Copy link
Member

The usual major/minor release deprecation, disables, removals.

Most notable here are:

  • dropping support for macOS versions under Catalina
  • dropping the Ubuntu 20.04 Docker image
  • deprecating support for --quarantine and --no-quarantine

Fixes #20755

@MikeMcQuaid MikeMcQuaid requested review from a team and Copilot November 4, 2025 14:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes Whalebrew support from Homebrew Bundle and updates several deprecated features to their disabled state. The changes include removing Whalebrew integration, deprecating environment variables, updating macOS version references in tests and documentation, and cleaning up deprecated methods.

Key Changes

  • Removal of Whalebrew support from brew bundle (including installer, dumper, tests, and documentation)
  • Deprecation of HOMEBREW_BREW_WRAPPER and HOMEBREW_NO_FORCE_BREW_WRAPPER environment variables
  • Updates to macOS version references from older versions (Mojave, Big Sur, Catalina) to newer ones (Sequoia, Sonoma, Ventura, Tahoe) across tests and documentation
  • Removal of deprecated methods (livecheckable?, Time#rfc3339, check_falsy_values)
  • Improvements to CLI parser deprecation/disabling handling
  • Removal of Ubuntu 20.04 Docker image support

Reviewed Changes

Copilot reviewed 49 out of 50 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
manpages/brew.1 Updated manpage with Whalebrew removal and environment variable deprecation notices
docs/Manpage.md Updated documentation to reflect Whalebrew removal and deprecated environment variables
docs/Support-Tiers.md Updated date reference from September to November 2025
docs/Brew-Bundle-and-Brewfile.md Removed Whalebrew acceptance criteria note
completions/* Removed Whalebrew options from shell completions (zsh, fish, bash)
Library/Homebrew/utils/string_inreplace_extension.rb Removed deprecated old_audit_result parameter from gsub! method
Library/Homebrew/test/support/fixtures/cask/Casks/invalid/conflicts-with-disabled-key.rb Fixed cask name from "deprecated" to "disabled"
Library/Homebrew/test/requirements/macos_requirement_spec.rb Updated tests to use Tahoe instead of Big Sur and newer macOS versions
Library/Homebrew/test/macos_version_spec.rb Updated tests from Mojave (10.14) to Catalina (10.15) and newer versions
Library/Homebrew/test/formula_spec.rb Updated tests to reference newer macOS versions
Library/Homebrew/test/cask/dsl_spec.rb Fixed terminology from "deprecated" to "disabled"
Library/Homebrew/test/bundle/* Removed Whalebrew-related tests and updated remaining tests
Library/Homebrew/resource.rb Removed deprecated livecheckable? method
Library/Homebrew/requirements/macos_requirement.rb Updated deprecated/disabled macOS versions lists
Library/Homebrew/macos_version.rb Simplified analytics pretty name method, removed old version mappings
Library/Homebrew/language/python.rb Uncommented odeprecated call for setup_install_args
Library/Homebrew/formula.rb Uncommented odeprecated calls and updated documentation example
Library/Homebrew/extend/time.rb Removed entire file containing deprecated Time#rfc3339 method
Library/Homebrew/env_config.rb Activated deprecation notices and removed check_falsy_values method
Library/Homebrew/dev-cmd/audit.rb Changed --token-conflicts from deprecated to disabled
Library/Homebrew/deprecate_disable.rb Removed deprecated :unsigned reason remapping
Library/Homebrew/cmd/* Updated CLI options to use new odeprecated: true syntax
Library/Homebrew/cli/parser.rb Enhanced switch handling with odeprecated and odisabled parameters
Library/Homebrew/cask/dsl/* Changed conflicts_with handling from deprecated to disabled
Library/Homebrew/bundle/* Removed Whalebrew support throughout bundle system
.github/workflows/docker.yml Removed Ubuntu 20.04 support
Files not reviewed (1)
  • Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi: Language not supported
Comments suppressed due to low confidence (1)

Library/Homebrew/test/macos_version_spec.rb:1

  • The hardcoded string "14" should use a constant or variable like MacOSVersion.new(\"14\") for consistency with other expectations in the test, or at minimum should reference the sonoma version that was defined in the range.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 49 out of 50 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid force-pushed the deprecate_disable branch 3 times, most recently from dac65f8 to 05cd996 Compare November 4, 2025 16:48
@MikeMcQuaid MikeMcQuaid marked this pull request as draft November 5, 2025 08:03
@MikeMcQuaid MikeMcQuaid force-pushed the deprecate_disable branch 4 times, most recently from e835da9 to 23b2c6b Compare November 5, 2025 10:01
@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review November 5, 2025 16:06
@MikeMcQuaid MikeMcQuaid enabled auto-merge November 5, 2025 16:20
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit 0c6d431 Nov 5, 2025
45 checks passed
@MikeMcQuaid MikeMcQuaid deleted the deprecate_disable branch November 5, 2025 16:48
LucasLarson added a commit to LucasLarson/dotfiles that referenced this pull request Nov 5, 2025
LucasLarson added a commit to LucasLarson/update that referenced this pull request Nov 5, 2025
LucasLarson added a commit to LucasLarson/dotfiles that referenced this pull request Nov 5, 2025
carlocab added a commit that referenced this pull request Nov 10, 2025
Without this change, the shim will never actually try to execute
`/usr/bin/git` on Linux, which results in confusing messages about `git`
being too old despite `/usr/bin/git` being new enough.

This partially restores code removed in #20973.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing support for --no-quarantine for casks

4 participants