-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Homebrew 4.7.0 deprecations/disables/removals #20973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes Whalebrew support from Homebrew Bundle and updates several deprecated features to their disabled state. The changes include removing Whalebrew integration, deprecating environment variables, updating macOS version references in tests and documentation, and cleaning up deprecated methods.
Key Changes
- Removal of Whalebrew support from
brew bundle(including installer, dumper, tests, and documentation) - Deprecation of
HOMEBREW_BREW_WRAPPERandHOMEBREW_NO_FORCE_BREW_WRAPPERenvironment variables - Updates to macOS version references from older versions (Mojave, Big Sur, Catalina) to newer ones (Sequoia, Sonoma, Ventura, Tahoe) across tests and documentation
- Removal of deprecated methods (
livecheckable?,Time#rfc3339,check_falsy_values) - Improvements to CLI parser deprecation/disabling handling
- Removal of Ubuntu 20.04 Docker image support
Reviewed Changes
Copilot reviewed 49 out of 50 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| manpages/brew.1 | Updated manpage with Whalebrew removal and environment variable deprecation notices |
| docs/Manpage.md | Updated documentation to reflect Whalebrew removal and deprecated environment variables |
| docs/Support-Tiers.md | Updated date reference from September to November 2025 |
| docs/Brew-Bundle-and-Brewfile.md | Removed Whalebrew acceptance criteria note |
| completions/* | Removed Whalebrew options from shell completions (zsh, fish, bash) |
| Library/Homebrew/utils/string_inreplace_extension.rb | Removed deprecated old_audit_result parameter from gsub! method |
| Library/Homebrew/test/support/fixtures/cask/Casks/invalid/conflicts-with-disabled-key.rb | Fixed cask name from "deprecated" to "disabled" |
| Library/Homebrew/test/requirements/macos_requirement_spec.rb | Updated tests to use Tahoe instead of Big Sur and newer macOS versions |
| Library/Homebrew/test/macos_version_spec.rb | Updated tests from Mojave (10.14) to Catalina (10.15) and newer versions |
| Library/Homebrew/test/formula_spec.rb | Updated tests to reference newer macOS versions |
| Library/Homebrew/test/cask/dsl_spec.rb | Fixed terminology from "deprecated" to "disabled" |
| Library/Homebrew/test/bundle/* | Removed Whalebrew-related tests and updated remaining tests |
| Library/Homebrew/resource.rb | Removed deprecated livecheckable? method |
| Library/Homebrew/requirements/macos_requirement.rb | Updated deprecated/disabled macOS versions lists |
| Library/Homebrew/macos_version.rb | Simplified analytics pretty name method, removed old version mappings |
| Library/Homebrew/language/python.rb | Uncommented odeprecated call for setup_install_args |
| Library/Homebrew/formula.rb | Uncommented odeprecated calls and updated documentation example |
| Library/Homebrew/extend/time.rb | Removed entire file containing deprecated Time#rfc3339 method |
| Library/Homebrew/env_config.rb | Activated deprecation notices and removed check_falsy_values method |
| Library/Homebrew/dev-cmd/audit.rb | Changed --token-conflicts from deprecated to disabled |
| Library/Homebrew/deprecate_disable.rb | Removed deprecated :unsigned reason remapping |
| Library/Homebrew/cmd/* | Updated CLI options to use new odeprecated: true syntax |
| Library/Homebrew/cli/parser.rb | Enhanced switch handling with odeprecated and odisabled parameters |
| Library/Homebrew/cask/dsl/* | Changed conflicts_with handling from deprecated to disabled |
| Library/Homebrew/bundle/* | Removed Whalebrew support throughout bundle system |
| .github/workflows/docker.yml | Removed Ubuntu 20.04 support |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi: Language not supported
Comments suppressed due to low confidence (1)
Library/Homebrew/test/macos_version_spec.rb:1
- The hardcoded string "14" should use a constant or variable like
MacOSVersion.new(\"14\")for consistency with other expectations in the test, or at minimum should reference the sonoma version that was defined in the range.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8541207 to
1745d52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 49 out of 50 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dac65f8 to
05cd996
Compare
e835da9 to
23b2c6b
Compare
23b2c6b to
c7c9c12
Compare
Homebrew/brew#20973 Signed-off-by: Lucas Larson <[email protected]>
Homebrew/brew#20973 Signed-off-by: Lucas Larson <[email protected]>
Homebrew/brew#20973 Signed-off-by: Lucas Larson <[email protected]>
Without this change, the shim will never actually try to execute `/usr/bin/git` on Linux, which results in confusing messages about `git` being too old despite `/usr/bin/git` being new enough. This partially restores code removed in #20973.
The usual major/minor release deprecation, disables, removals.
Most notable here are:
--quarantineand--no-quarantineFixes #20755