-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Add a flag and an environment variable to skip bundling Go packages #20989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The similar idea to the `--no-vscode` flag.
Generate completion files to support typing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new --no-go flag to the brew bundle command, allowing users to exclude Go packages when running dump. This mirrors the existing --no-vscode flag functionality.
- Adds
--no-goflag with environment variable support (HOMEBREW_BUNDLE_DUMP_NO_GO) - Implements mutual exclusivity between
--go/--no-goand--all/--no-go - Updates completion scripts and documentation to reflect the new flag
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/cmd/bundle.rb | Adds --no-go switch definition, conflict rules, and conditional logic for the dump command |
| Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi | Adds type signature for the no_go? method |
| manpages/brew.1 | Adds manpage entry for the --no-go flag |
| docs/Manpage.md | Adds documentation for the --no-go flag |
| completions/zsh/_brew | Updates zsh completions to include --no-go and its mutual exclusivity rules |
| completions/fish/brew.fish | Adds fish shell completion for --no-go |
| completions/bash/brew | Adds bash completion for --no-go |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Enable to pass the tests.
Rylan12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @5ouma!
I'll let someone who's touched brew bundle more recently take a look tomorrow before merging just in case
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @5ouma!
Installing Go packages was added in #20798, but it can't be opted out of.
This is a similar idea to
--no-vscode.ref: #20645 (comment)
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally