Skip to content

Conversation

@5ouma
Copy link
Contributor

@5ouma 5ouma commented Nov 6, 2025

Installing Go packages was added in #20798, but it can't be opted out of.
This is a similar idea to --no-vscode.
ref: #20645 (comment)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally

5ouma added 2 commits November 6, 2025 11:31
The similar idea to the `--no-vscode` flag.
Generate completion files to support typing.
Copilot AI review requested due to automatic review settings November 6, 2025 02:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new --no-go flag to the brew bundle command, allowing users to exclude Go packages when running dump. This mirrors the existing --no-vscode flag functionality.

  • Adds --no-go flag with environment variable support (HOMEBREW_BUNDLE_DUMP_NO_GO)
  • Implements mutual exclusivity between --go/--no-go and --all/--no-go
  • Updates completion scripts and documentation to reflect the new flag

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Library/Homebrew/cmd/bundle.rb Adds --no-go switch definition, conflict rules, and conditional logic for the dump command
Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi Adds type signature for the no_go? method
manpages/brew.1 Adds manpage entry for the --no-go flag
docs/Manpage.md Adds documentation for the --no-go flag
completions/zsh/_brew Updates zsh completions to include --no-go and its mutual exclusivity rules
completions/fish/brew.fish Adds fish shell completion for --no-go
completions/bash/brew Adds bash completion for --no-go
Files not reviewed (1)
  • Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Enable to pass the tests.
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @5ouma!

I'll let someone who's touched brew bundle more recently take a look tomorrow before merging just in case

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @5ouma!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 6, 2025
Merged via the queue into Homebrew:main with commit d0b3360 Nov 6, 2025
37 checks passed
@5ouma 5ouma deleted the feat-cmd-bundle-no-go branch November 6, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants