Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Nov 10, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

So that documentation is updated at places like https://docs.brew.sh/rubydoc/Formula.html#depends_on-class_method

Copilot AI review requested due to automatic review settings November 10, 2025 13:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates code examples in the formula documentation to reflect current best practices and syntax conventions.

  • Replaces deprecated conditional syntax with modern on_<version> block syntax
  • Updates fails_with example to use keyword arguments instead of hash rockets
  • Standardizes string quotes to use double quotes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 10, 2025
Merged via the queue into main with commit 4145fc1 Nov 10, 2025
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the formula-comment-DSL-style branch November 10, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants