test_bot/test_cleanup: run git clean on taps
#21025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1] intentionally skipped `git clean` on taps for some reason that I cannot tell, but doing so does help us to clean up untracked files in taps and thus avoiding issues like [2]. [1]: Homebrew/homebrew-test-bot@7d5274a [2]: https://github.com/orgs/Homebrew/discussions/6517
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds git clean operations on taps during test cleanup to remove untracked files, addressing issues where untracked files in taps could cause problems. The PR also fixes a typo where a closing parenthesis was missing in a string interpolation.
- Adds
clean_if_needed(git_repo)call to cleanup taps alongside existing reset and prune operations - Fixes missing closing parenthesis in GitHub repository string interpolation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/test_bot/test_cleanup.rb | Adds clean_if_needed call for tap repositories to clean up untracked files during test cleanup |
| Library/Homebrew/test_bot.rb | Fixes missing closing parenthesis in tap_github variable assignment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
I tested the fix in my tap, it works pretty good. Thanks @ZhongRuoyu! |
Open
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Homebrew/homebrew-test-bot@7d5274a intentionally skipped
git cleanon taps for some reason that I cannot tell, but doing so does help us to clean up untracked files in taps and thus avoiding issues like 1.Footnotes
https://github.com/orgs/Homebrew/discussions/6517 ↩