upgrade: tweak linkage handling. #21063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MikeMcQuaid
commented
Nov 14, 2025
MikeMcQuaid
commented
- Remove no-op linkage checks before upgrades are done
- Only check linkage of non-core formulae after upgrades are done
- Remove no-op linkage checks before upgrades are done - Only check linkage of non-core formulae after upgrades are done
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the upgrade process by removing redundant linkage checks and scoping post-upgrade linkage validation to non-core formulae only.
- Removes pre-upgrade broken dependent checks that were not being used effectively
- Restricts post-upgrade linkage validation to non-core formulae since core formulae are validated during CI
- Adds early return when no non-core formulae require linkage checking
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.