Skip to content

Conversation

@XXXXRT666
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Fix #21102

Copilot AI review requested due to automatic review settings November 18, 2025 07:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the URL construction for portable Ruby downloads when using custom brew mirrors via HOMEBREW_BOTTLE_DOMAIN. The change removes the hardcoded /bottles-portable-ruby/ subdirectory path that was incorrectly assumed to exist on all mirror servers.

Key changes:

  • Simplified the portable Ruby URL construction for custom bottle domains to use just the filename without assuming internal directory structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 18, 2025
Merged via the queue into Homebrew:main with commit 6c47ccd Nov 18, 2025
80 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not update brew when USER_HOMEBREW_BOTTLE_DOMAIN set

2 participants