bundle/commands/install_spec: fix flaky test. #21104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to reset this so doubles don't escape.
MikeMcQuaid
force-pushed
the
fix_flaky_test
branch
from
756a71c to
36de875
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky test in the bundle/commands/install_spec by ensuring the CaskDumper module state is properly reset between test runs. The changes prevent test doubles from leaking between tests, which was causing intermittent test failures.
Key Changes
- Added
require "bundle/cask_dumper"import to enable access to the CaskDumper module - Added a
beforeblock that callsHomebrew::Bundle::CaskDumper.reset!to clear memoized state before each test in the "when a Brewfile is found" context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bevanjkay
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to reset this so doubles don't escape: https://github.com/Homebrew/brew/actions/runs/19458118271/job/55676016850?pr=21103