utils/linkage: allow checking non-brew libraries #21115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?This allows replacing some Homebrew/core system library checks where we are using
Pathname#dynamically_linked_libraries(which will break if we stop monkey-patching Pathname).For example
The previous code skipped over non-Homebrew libraries and would always run realpath which is not guaranteed to exist for macOS system libraries.
This won't handle checking a symlinked system library. However, this feature isn't needed as it would only be used for Linux libraries but we already audit unwanted system library linkage.
If there is ever a case we want to check symlinked system library, could add an
exist?check and then runrealpath.