linux/cask/artifact/relocated: fix type error. #21154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to fully qualify the Pathname class to avoid runtime Sorbet errors.
bevanjkay
approved these changes
Dec 1, 2025
Member
bevanjkay
left a comment
bevanjkay
left a comment
There was a problem hiding this comment.
Works for me 👍 Thanks @MikeMcQuaid
Copilot finished reviewing on behalf of
MikeMcQuaid
December 1, 2025 09:30
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Sorbet type error in the Linux-specific override for the Cask artifact relocated module by fully qualifying the Pathname class references in the type signature. This change addresses issue #21147.
Key changes:
- Updated the
add_altname_metadatamethod signature to use::Pathnameinstead ofPathnamefor both thefileandaltnameparameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to fully qualify the Pathname class to avoid runtime Sorbet errors.
Fixes #21147