Skip to content

Conversation

@botantony
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

#21186 (comment)

Copilot AI review requested due to automatic review settings December 7, 2025 16:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request improves type safety in the GitHubPackages class by explicitly casting pkg_version and rebuild values to match their declared Sorbet type signatures (Version and Integer respectively). This ensures consistency between the data extracted from untyped hash structures and the method signatures that consume them.

Key Changes

  • Cast pkg_version from hash to Version object using Version.new()
  • Cast rebuild from hash to Integer using .to_i
  • Remove redundant .to_i call on rebuild parameter in version_rebuild method since the parameter is already typed as Integer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@botantony botantony added this pull request to the merge queue Dec 7, 2025
Merged via the queue into main with commit 9d48a58 Dec 7, 2025
43 checks passed
@botantony botantony deleted the github_packages-type-fix branch December 7, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants