Skip to content

Move Cask specs into brew tests. #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reitermarkus merged 4 commits into from
Mar 5, 2017
Merged

Move Cask specs into brew tests. #2260

reitermarkus merged 4 commits into from
Mar 5, 2017

Conversation

@reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Mar 5, 2017 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

@reitermarkus reitermarkus force-pushed the spec-cask branch 3 times, most recently from 0e98262 to a39af59 Compare March 5, 2017 07:30
MikeMcQuaid
MikeMcQuaid approved these changes Mar 5, 2017
View reviewed changes
Library/Homebrew/cask/cmd/brew-cask-tests.rb Outdated
Copy link
Member

@MikeMcQuaid MikeMcQuaid Mar 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does brew cask-tests do now?

Copy link
Member Author

@reitermarkus reitermarkus Mar 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing, but it is still needed because test-bot still calls it.

@reitermarkus reitermarkus force-pushed the spec-cask branch 8 times, most recently from db058ac to be17abc Compare March 5, 2017 22:07
@reitermarkus
Copy link
Member Author

reitermarkus commented Mar 5, 2017

Finally coverage is (seems to be, at least 😉 ) working.

@reitermarkus reitermarkus merged commit 1fbd720 into Homebrew:master Mar 5, 2017
@reitermarkus reitermarkus deleted the spec-cask branch March 5, 2017 22:31
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Mar 6, 2017

@reitermarkus Nice work 👏

@MikeMcQuaid MikeMcQuaid mentioned this pull request Mar 6, 2017
Merged
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reitermarkus @MikeMcQuaid