blacklist - remove clojure #3083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puredanger
added a commit
to puredanger/homebrew-core
that referenced
this pull request
Aug 23, 2017
This is a new formula for Clojure (the language) to install the Clojure repl tool (`clj`). This tool has been created by the Clojure core team (of which I am a member) for the upcoming Clojure 1.9.0 release. There are two audit failures: 1) devel-only: Clojure 1.9.0 is currently in alpha, so this is a devel-only formula targeted at Clojure 1.9.0-alpha18. We expect this to be updated in the next few months to a stable 1.9.0 version when it's available. For now, this lets our users provide feedback on this new tool prior to its official release. 2) blacklist: Clojure is currently in the brew blacklist. I have created a separate PR to remove clojure from the blacklist at Homebrew/brew#3083. Presumably that PR needs to be applied before this formula can be accepted.
4 tasks
Contributor
Author
|
See Homebrew/homebrew-core#17151 for the new clojure formula PR |
MikeMcQuaid
approved these changes
Aug 23, 2017
Member
|
Seems reasonable! Thanks for your first contribution to Homebrew, @puredanger! Without people like you submitting PRs we couldn't run this project. You rock! |
Contributor
Author
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Currently there is a blacklist entry for "clojure" (the language) that points you towards installing "leiningen" instead, which is the most popular Clojure build tool and the easiest path to a Clojure REPL, so this made good sense until now.
However, the next release of Clojure (1.9.0) will include a Clojure REPL tool (called
clj). I am a member of the Clojure core team and I have a separate PR ready to submit with a formula forclojurethat includes this tool, but the blacklist entry needs to be removed before that formula can be added.This patch removes the blacklist for
clojureand the test checking the blacklist forclojure.