Skip to content

Fix brew tests leaving last file in trash. #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reitermarkus merged 2 commits into from
Oct 2, 2017
Merged

Fix brew tests leaving last file in trash. #3247

reitermarkus merged 2 commits into from
Oct 2, 2017

Conversation

@reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 30, 2017 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Fixes #2974 (comment).

@reitermarkus reitermarkus mentioned this pull request Sep 30, 2017
Closed
4 tasks
ilovezfs
ilovezfs reviewed Oct 1, 2017
View reviewed changes
Library/Homebrew/cask/lib/hbc/artifact/abstract_uninstall.rb Outdated
Copy link
Contributor

@ilovezfs ilovezfs Oct 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chomp! doesn't work?

Copy link
Member Author

@reitermarkus reitermarkus Oct 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chomp doesn't work on the \r\n edge case.

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Oct 1, 2017

@reitermarkus This is still not fixing #2974. Please guard this test for ENV["CI"] or something similar or I'm just going to remove the test entirely within a few days.

@reitermarkus
Copy link
Member Author

reitermarkus commented Oct 1, 2017

Guarded it with HOMEBREW_TESTS_COVERAGE.

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Oct 2, 2017

Thanks @reitermarkus!

@reitermarkus reitermarkus merged commit 23da0aa into Homebrew:master Oct 2, 2017
@reitermarkus reitermarkus deleted the fix-trash branch October 2, 2017 12:02
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

+1 more reviewer

@ilovezfs ilovezfs ilovezfs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reitermarkus @MikeMcQuaid @ilovezfs