Skip to content

InternalAuditModifiedCask: audit renamed Casks #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reitermarkus merged 1 commit into from
Oct 7, 2017
Merged

InternalAuditModifiedCask: audit renamed Casks #3280

reitermarkus merged 1 commit into from
Oct 7, 2017

Conversation

@commitay
Copy link
Contributor

@commitay commitay commented Oct 7, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Refs:

Allows _audit_modified_casks to check Casks that have been renamed.

@commitay commitay mentioned this pull request Oct 7, 2017
Merged
@reitermarkus reitermarkus merged commit 62315e9 into Homebrew:master Oct 7, 2017
@reitermarkus
Copy link
Member

reitermarkus commented Oct 7, 2017

Nice catch, @commitay!

@commitay commitay deleted the cask-internal-audit branch October 7, 2017 13:58
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@reitermarkus reitermarkus reitermarkus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@commitay @reitermarkus