Refactor MacOS::languages.
#3296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Oct 9, 2017
Library/Homebrew/os/mac.rb
Outdated
Member
There was a problem hiding this comment.
The @languages ||= begin pattern I think is generally nicest here but don't feel super strongly.
Library/Homebrew/os/mac.rb
Outdated
Member
There was a problem hiding this comment.
@languages.prepend or something feels nicer?
Member
Author
There was a problem hiding this comment.
Doesn't really feel nicer to me.
Member
There was a problem hiding this comment.
It feels a little weird to be doing a splat on @languages inside it's own assignment.
Member
Author
There was a problem hiding this comment.
It's now all in one assignment.
reitermarkus
force-pushed
the
refactor-languages
branch
from
e90aaff to
5b8a3d3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.