commands: filter out dotfiles from output

[DomT4]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you successfully run brew tests with your changes locally?

---

Noticed in this that DS_Store was getting chucked in with the commands list 🤷‍♂️.

[ilovezfs]

not all dot files?

[DomT4]

I can if you want? Just thought this was the only one that seemed likely to end up inside a cmd folder unless someone is doing something a little strange with their tap/etc.

[ilovezfs]

It will currently list e.g. .info.rb.swp so I would do all dot files, yeah

[DomT4]

Alright. One sec.

[reitermarkus]

How about

  Pathname.glob(directory/"*")
          .select(&:file?)
          .map { |f| f.basename.to_s.sub(/\.(?:rb|sh)$/, "") }

?

[DomT4]

I don't have a major objection if people prefer that format. Whatever folks are happy with. I am not a huge fan of chaining together across multiple lines like that but it's become a common enough thing I can't really start complaining about it now 😄.

[reitermarkus]

I find it easier to follow than a next inside an if inside an each_with_object. 😉

[DomT4]

@ilovezfs Any objections? Keen to avoid getting in the middle of a maintainer disagreement over style. I don't miss those 😅.

[MikeMcQuaid]

Thanks @DomT4 and @reitermarkus!

[DomT4]

Thanks for merging Mike. Was trying to give ILZ a little bit to see if he had any objections, but I'm assuming we're good.

[ilovezfs]

LGTM. Thanks, Mr. T