Use patch found in the PATH

[sjackman]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew tests with your changes locally?

[MikeMcQuaid]

I'd rather we avoid any more of these until environment filtering is on by default. I think then we can just remove the hardcoded /usr/bin pretty much everywhere. Thoughts?

[sjackman]

I think then we can just remove the hardcoded /usr/bin pretty much everywhere.

That would be awesome.

[sjackman]

Before I read your comment, I came up with a better solution using with_system_path. It may still be worth applying, even in advance of environment filtering. After environment filtering, we may be able to get rid of with_system_path and its callers.

[MikeMcQuaid]

Before I read your comment, I came up with a better solution using with_system_path

I think this kinda changes the meaning of with_system_path, though.

[MikeMcQuaid]

Let's try just changing this to patch below and not use a variable (i.e. remove the /usr/bin). If it goes 💥
I'll revert it.

[sjackman]

I got rid of the cmd variable. Did you mean also get rid of with_system_path?

[MikeMcQuaid]

@sjackman Yep; make this just remove /usr/bin/ and the variable usage.

[sjackman]

Done. I also replaced IO.popen with Utils.popen_write.

[sjackman]

Before I read your comment, I came up with a better solution using with_system_path

I think this kinda changes the meaning of with_system_path, though.

You may not find the desired utility in /usr/bin or /bin on a Linux system, where it makes sense to use the brewed version of the utility, if it's installed. It could be renamed to with_sanitized_path.

[MikeMcQuaid]

Thanks again @sjackman!

[sjackman]

No worries. Thanks for merging, Mike.

[MikeMcQuaid]

@sjackman Now that environment filtering is on by default @sjackman you can feel free to do this anywhere else that makes sense (and remove a bunch of with_system_path usage, too.

[sjackman]

Fantastic!