Skip to content

Adjust macOS version logic#9225

Merged
MikeMcQuaid merged 1 commit into
Homebrew:masterfrom
MikeMcQuaid:adjust_prerelease_logic
Nov 23, 2020
Merged

Adjust macOS version logic#9225
MikeMcQuaid merged 1 commit into
Homebrew:masterfrom
MikeMcQuaid:adjust_prerelease_logic

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • Adjust latest supported macOS logic for e.g. Big Sur 11.1.
  • Updated latest supported version in docs to Mojave

Fixes #9211

Comment thread docs/Installation.md Outdated
- Adjust latest supported macOS logic for e.g. Big Sur 11.1.
- Updated latest supported version in docs to Mojave

Fixes #9211
@reitermarkus
Copy link
Copy Markdown
Member

Does MacOS.version == :big_sur work when it's 11.1?

@MikeMcQuaid MikeMcQuaid merged commit 26c1d43 into Homebrew:master Nov 23, 2020
@MikeMcQuaid MikeMcQuaid deleted the adjust_prerelease_logic branch November 23, 2020 08:04
@MikeMcQuaid
Copy link
Copy Markdown
Member Author

@reitermarkus Good catch: it does not. Would you be able to pick that up?

@fxcoudert
Copy link
Copy Markdown
Member

I think we need more extensive changes to the version number handling. For example, there are many places that assume that MacOS.version only tracks major versions (not minor versions, like MacOS.full_version). Therefore, to keep the semantics, MacOS.version should return 11 (and not 11.0 or 11.x) on all Big Sur versions.

Comment thread docs/Installation.md
[Tigerbrew](https://github.com/mistydemeo/tigerbrew).

<a name="2"><sup>2</sup></a> 10.13 or higher is recommended. 10.9–10.12 are
<a name="2"><sup>2</sup></a> 10.14 or higher is recommended. 10.9–10.13 are
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid hi. so if I understand correctly, this is where you dropped support for 10.13? What does "supported on a best-effort basis" mean? My home-brew installation is no longer working after the latest upgrade, unfortunately. And I am still unable to upgrade from 10.13 (because I still need Aperture). Any advice? Can I go back to the version before this one somehow? I know that some packages probably won't work but that's still better than an entirely broken homebrew installation. Thanks for any advice!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Aperture runs on Mojave, which Apple still supports, and so do we)

"supported on a best-effort basis" means we won't break it deliberately, and if it gets broken and we are provided with a simple fix, we'll review and include it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is where you dropped support for 10.13?

Yes.

"supported on a best-effort basis" means we won't break it deliberately, and if it gets broken and we are provided with a simple fix, we'll review and include it.

Yes but Homebrew maintainers are unlikely to fix problems on 10.13 and binary packages on 10.13 are likely to disappear over time.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys! This community is awesome. @fxcoudert I had somehow missed that Aperture is also supported on Mojave. I'll move up one minor version for now 😄. That'll probably be easier for me than trying to submit a PR to fix my issue with 10.13.

Keep up the good work!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change version comparison behaviour for macOS version ≥ 11

6 participants