This repository was archived by the owner on Apr 18, 2024. It is now read-only.
fix: HumanSignal/label-studio#4386: Added tag-selected mode for visibleWhen#1614
Open
ftesser wants to merge 2 commits intoHumanSignal:masterfrom
Open
fix: HumanSignal/label-studio#4386: Added tag-selected mode for visibleWhen#1614ftesser wants to merge 2 commits intoHumanSignal:masterfrom
ftesser wants to merge 2 commits intoHumanSignal:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
As described in HumanSignal/label-studio#4386 in label studio version 1.7.3
visibleWhen="choice-selected" whenTagName="name"worked clicking on the label.With label studio version > 1.7.3 that does not work any-more.
I realized that the difference was caused by commit 791b713.
I suppose that it was probably an unintended effect in label studio version <= 1.7.3
So I propose to add a new variant for visibleWhen:
visibleWhen="tag-selected" whenTagName="name"to have the same behaviour: shows panes clicking on the label.What does this fix?
Fix: HumanSignal/label-studio#4386
Now using
visibleWhen="tag-selected"the following labeling interface as follows:What is the new behavior?
Shows additional panels clicking on the label.
No click:

Click:

What is the current behavior?
choice-selecteddoesn't work like label studio version <= 1.7.3What libraries were added/updated?
None.
Does this change affect performance?
No.
Does this change affect security?
No.
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)