Skip to content

feat: LEAP-2012: Add official docs remaining plugins to the repo#10

Merged
nass600 merged 2 commits intomainfrom
fb-leap-2012/add-repos
Apr 16, 2025
Merged

feat: LEAP-2012: Add official docs remaining plugins to the repo#10
nass600 merged 2 commits intomainfrom
fb-leap-2012/add-repos

Conversation

@nass600
Copy link
Contributor

@nass600 nass600 commented Apr 16, 2025

Description

Added 2 new plugins based on the docs:

Merged docs plugin with a existing one:

Related Issues

Fixed a bug with pausing annotator restoring the reason to pause to CUSTOM_SCRIPT

Checklist

  • I have tested the changes in the Label Studio Labeling Config.
  • I have added the plugin.js file.
  • I have added the view.xml file.
  • My code follows the guidelines stated in the README.md.

Copy link
Contributor

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions to our plugin gallery!
There are some questions and suggestions to make code better and cleaner.
Also would be great to use better approach to Bulk labeling from the script we already have, but it's okay to do it later in a separate PR (reference)

Copy link

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, though minor nitpick - we should have biome rules apply here - so our codebases coding styles are consistent - one thing that I found distracting while reviewing this PR was the 4 spaces per tab but thats a non-blocker for purposes of this ticket

@nass600 nass600 merged commit 1baaecf into main Apr 16, 2025
4 checks passed
@nass600 nass600 deleted the fb-leap-2012/add-repos branch April 16, 2025 16:19
@hlomzik
Copy link
Contributor

hlomzik commented Apr 21, 2025

oh, all these files have tabs instead of spaces... yeah, we should definitely apply proper linting rules here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants