Skip to content

Update weather command to use location variable#1189

Merged
kRHYME7 merged 2 commits intoHyDE-Project:devfrom
realRobotix:realRobotix-weather-lock-fix
Aug 27, 2025
Merged

Update weather command to use location variable#1189
kRHYME7 merged 2 commits intoHyDE-Project:devfrom
realRobotix:realRobotix-weather-lock-fix

Conversation

@realRobotix
Copy link
Contributor

should probably use the weather script but that would require making it more general purpose instead of just for waybar

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • Make sure to make PR against dev and not the master
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

should probably use the weather script but that would require making it more general purpose instead of just for waybar
@github-actions
Copy link
Contributor

⚠️ Warning: PR targeting master branch detected!

This PR is targeting master but should target dev instead.

According to our Quarterly Release Policy:

  • All pull requests must be submitted to the dev branch
  • Changes go through dev first for testing before being merged to master during quarterly release windows (1st & 3rd Fridays)
  • PRs to master are only allowed for emergencies

Required Action:

  1. Change the base branch from master to dev
  2. Follow the pull request template

If this is an emergency fix, please add a comment explaining why it needs to target master directly.


This is an automated message enforcing our quarterly release workflow.

@realRobotix realRobotix changed the base branch from master to dev August 26, 2025 20:46
@kRHYME7
Copy link
Contributor

kRHYME7 commented Aug 27, 2025

tested and works?

@realRobotix
Copy link
Contributor Author

yes ofc

@kRHYME7 kRHYME7 merged commit a012e4d into HyDE-Project:dev Aug 27, 2025
4 checks passed
kRHYME7 added a commit that referenced this pull request Aug 30, 2025
This is an automated PR to promote changes from `dev` to `rc`.
Please review and test before merging.

See [TESTING.md](./TESTING.md) for complete testing instructions.

According to our release policy, this PR is expected to be merged
during: **Freeze Week (see release policy)**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.

---
* fix: calc (259f2cc) by kRHYME7
* fix: Autofix non existent theme wallpaper cache (35831be) by kRHYME7
* chore Update weather command to use location variable (#1189)
(a012e4d) by Khing
* chore Merge branch 'dev' into realRobotix-weather-lock-fix (4c62365)
by Khing
* chore Update weather command to use location variable (e99a865) by
Robotix
* chore Merge branch 'rc' into dev (2116d22) by Khing
* chore Merge branch 'rc' into dev (df3fb1a) by Khing
* fix: missing exec in logout keybind (#1181) (7e6324c) by Khing
* fix: missing exec in logout keybind (6dec7ee) by amit
* chore Merge branch 'rc' into dev (9ccebaa) by Khing
* chore Fix: handle when waybar is missing (f422606) by kRHYME7
* feat (binds): Use `hyde-shell logout` for cleaner session logout
(1d0e669) by kRHYME7
* chore Fix: pypr when no nc or socat command (5321359) by kRHYME7
* chore Fix: pypr when no nc or socat command (b529c94) by kRHYME7
* chore - Waybar: Make temperature background transparent - hyde-shell:
silent pyinit command (151391e) by kRHYME7
* chore Merge branch 'rc' into dev (ca47fd0) by Khing
---

Please review the changes carefully before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants