Add finish line drawing to race replay UI#94
Merged
IAmTomShaw merged 4 commits intoIAmTomShaw:mainfrom Jan 10, 2026
Merged
Conversation
Introduced a new draw_finish_line function in ui_components.py to render a checkered finish line on the track. Integrated this function into the F1RaceReplayWindow rendering flow in race_replay.py to visually indicate the race finish line.
Owner
|
Are you able to add this to the Qualifying interface too? :) |
Contributor
Author
|
doing it now sir 😄 |
Updated the draw_finish_line function to support both qualifying and race sessions by accepting a session_type parameter. Modified QualifyingReplay to use the new draw_finish_line logic and refactored track drawing to store inner and outer points as instance variables.
Contributor
Author
|
hi @IAmTomShaw, extended to qualifying as well. 
|
Contributor
Author
|
Hi @IAmTomShaw, this is implemented and can be merged I guess 😄 |
Contributor
Author
|
Hi @IAmTomShaw, any updates when you're free thanks 😊 |
Owner
|
Sorry I missed this. Great work! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new draw_finish_line function in ui_components.py to render a checkered finish line on the track. Integrated this function into the F1RaceReplayWindow rendering flow in race_replay.py to visually indicate the race finish line.
@IAmTomShaw , this should add some visual cue for users to track the finish of the drivers on the track