feat(producer): add MaxBufferBytes to limit retry buffer size#3088
Merged
feat(producer): add MaxBufferBytes to limit retry buffer size#3088
Conversation
e7f5cbc to
1524102
Compare
puellanivis
reviewed
Jan 28, 2025
1524102 to
e9ec73a
Compare
Contributor
Author
|
@dnwe can you please review this PR? Thanks! |
puellanivis
reviewed
Jan 28, 2025
Collaborator
puellanivis
left a comment
There was a problem hiding this comment.
The only thing left to comment about is a possible alternative, that may or may not be an improvement.
Otherwise, this looks like it does what it intends.
Signed-off-by: Wenli Wan <swwl1992@gmail.com>
e9ec73a to
7291db1
Compare
dnwe
approved these changes
Jan 28, 2025
Collaborator
dnwe
left a comment
There was a problem hiding this comment.
Thank you for this contribution, and for refining it based on the review feedback. The changes LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the MaxBufferBytes configuration to Sarama’s producer, allowing users to limit the retry buffer size based on the total byte size of messages. This complements the existing MaxBufferLength configuration, which limits the number of messages in the retry buffer. The implementation ensures more robust control over memory usage and prevents potential OOM issues when dealing with large messages.
The changes are built upon the foundation laid in #3026, further enhancing the retry buffer’s configurability and usability.
Key Changes
This enhancement allows users to fine-tune producer behavior, particularly when working with large message payloads or memory-constrained environments.