chore: tear down zk in functional tests#3420
Merged
Conversation
… static membership test This commit simplifies the error handling in the `TestFuncConsumerGroupStaticMembership_RejoinAndLeave` test by removing a redundant error check. Additionally, it updates the error messages to correctly reflect the expected and actual generation IDs for better clarity in test failures. Signed-off-by: Edoardo Comar <ecomar@uk.ibm.com>
…keeper profile for Kafka versions < 4.0.0 This update modifies the `tearDownDockerTestEnvironment` function to conditionally include the zookeeper profile in Docker commands when the Kafka version is less than 4.0.0. This ensures proper shutdown of zookeeper containers, improving the reliability of the test environment teardown process. Signed-off-by: Edoardo Comar <ecomar@uk.ibm.com>
Signed-off-by: Edoardo Comar <ecomar@uk.ibm.com>
edoardocomar
force-pushed
the
update-snappy
branch
from
4b5978c to
af8bcb0
Compare
dnwe
changed the title
dnwe
approved these changes
Jan 9, 2026
Collaborator
|
Thanks! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove duplicate error check and update error messages in functional_consumer_staticmembership_test
enhance tearDownDockerTestEnvironment to support zookeeper profile for Kafka versions < 4.0.0
This update modifies the
tearDownDockerTestEnvironmentfunction to conditionally include the zookeeper profile in Docker commands when the Kafka version is less than 4.0.0. This ensures proper shutdown of zookeeper containers, improving the reliability of the test environment teardown process.update github.com/golang/snappy from v0.0.4 to