-
Notifications
You must be signed in to change notification settings - Fork 160
Closed
Labels
✅ status: resolvedApplies to issues that have pending PRs resolving them, or PRs that have already merged.Applies to issues that have pending PRs resolving them, or PRs that have already merged.overlayrefactoringtriage: blockingversion: 15.1.x
Description
Since the ComponentFactory is deprecated and the new way of creating dynamic components in Angular is done through the viewContainerRef I think we should update our Overlay's attach with an overload that accepts a viewContainerRef. The current overload:
igniteui-angular/projects/igniteui-angular/src/lib/services/overlay/overlay.ts
Lines 321 to 322 in a7aebb0
| public attach(component: Type<any>, settings?: OverlaySettings, | |
| moduleRef?: Pick<NgModuleRef<any>, 'injector' | 'componentFactoryResolver'>): string; |
Should be deprecated - the sooner the better, so we can have a transition period before the old API is dropped.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
✅ status: resolvedApplies to issues that have pending PRs resolving them, or PRs that have already merged.Applies to issues that have pending PRs resolving them, or PRs that have already merged.overlayrefactoringtriage: blockingversion: 15.1.x