Skip to content

Deselect cell with ctrl + click#12621

Merged
kdinev merged 12 commits intomasterfrom
mkirkova/feat-12522
Mar 7, 2023
Merged

Deselect cell with ctrl + click#12621
kdinev merged 12 commits intomasterfrom
mkirkova/feat-12522

Conversation

@MonikaKirkova
Copy link
Contributor

@MonikaKirkova MonikaKirkova commented Feb 7, 2023 •
edited
Loading

Closes #12522
Closes #9086

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@hanastasov hanastasov removed the ❌ status: awaiting-test PRs awaiting manual verification label Feb 21, 2023
@hanastasov hanastasov requested review from ddincheva and removed request for hanastasov February 21, 2023 10:00
ddincheva
ddincheva reviewed Feb 22, 2023
View reviewed changes
@ddincheva
Copy link
Contributor

ddincheva commented Feb 22, 2023 •
edited
Loading

The range selection with the keyboard using ctrl +shift + arrow keys is broken:
RANGEselectionGrid
Same on master:
RANGEselectionGridMaster

@teodosiah teodosiah added the 🛠️ status: in-development Issues and PRs with active development on them label Feb 23, 2023
@MonikaKirkova MonikaKirkova added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 6, 2023
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 6, 2023
@ddincheva ddincheva self-requested a review March 7, 2023 07:25
@ddincheva ddincheva added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Mar 7, 2023
@kdinev kdinev merged commit e492fab into master Mar 7, 2023
@kdinev kdinev deleted the mkirkova/feat-12522 branch March 7, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ddincheva ddincheva ddincheva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

grid: multi-cell-selection version: 15.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

5 participants

@MonikaKirkova @ddincheva @kdinev @hanastasov @teodosiah