Skip to content

Generate child igx-hierarchical-grids dynamically.#12855

Merged
kdinev merged 1 commit intomasterfrom
mkirova/fix-12765
Apr 6, 2023
Merged

Generate child igx-hierarchical-grids dynamically.#12855
kdinev merged 1 commit intomasterfrom
mkirova/fix-12765

Conversation

@MayaKirova
Copy link
Contributor

@MayaKirova MayaKirova commented Apr 4, 2023

Closes #12765

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova
Copy link
Contributor Author

MayaKirova commented Apr 4, 2023

Note that in order to reproduce the issue you need to go to the branch from: #12699
Add IgxChildGridRowComponent to the IgxHierarchicalGridComponent imports:

@Component({
    changeDetection: ChangeDetectionStrategy.OnPush,
    selector: 'igx-hierarchical-grid',
    templateUrl: 'hierarchical-grid.component.html',
    providers: [
      ...
    ],
    standalone: true,
    imports: [
        ...,
        IgxChildGridRowComponent
    ],
    schemas: [CUSTOM_ELEMENTS_SCHEMA]
})
export class IgxHierarchicalGridComponent ...

And then run the hierarchical grid tests.
All will fail due to import stack overflow:
image

When testing with changes from this branch and removing the IgxHierarchicalGridComponent import from the IgxChildGridRowComponent :

@Component({
    changeDetection: ChangeDetectionStrategy.OnPush,
    selector: 'igx-child-grid-row',
    templateUrl: './child-grid-row.component.html',
    standalone: true,
   imports: [NgClass, forwardRef(() => IgxHierarchicalGridComponent)]  //delete this
})
export class IgxChildGridRowComponent implements AfterViewInit, OnInit {

No such global error should occur.

@skrustev skrustev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Apr 5, 2023
@kdinev kdinev merged commit a822aee into master Apr 6, 2023
@kdinev kdinev deleted the mkirova/fix-12765 branch April 6, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: hierarchical-grid version: 16.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate child igx-hierarchical-grids dynamically

5 participants