Skip to content

feat(tabs): implement manual and auto activation modes for keyboard navigation - master#14858

Merged
kacheshmarova merged 10 commits intomasterfrom
ganastasov/feat-14839-master
Oct 18, 2024
Merged

feat(tabs): implement manual and auto activation modes for keyboard navigation - master#14858
kacheshmarova merged 10 commits intomasterfrom
ganastasov/feat-14839-master

Conversation

@georgianastasov
Copy link
Contributor

@georgianastasov georgianastasov commented Oct 1, 2024

Closes #14839

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ChronosSF
Copy link
Member

@georgianastasov , @kacheshmarova , can anyone from your team validate this? We are trying to close 18.2 and if this doesn't get in master in a few days tops it's going to be left for 19.x

gedinakova
gedinakova previously approved these changes Oct 18, 2024
@RivaIvanova RivaIvanova self-assigned this Oct 18, 2024
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 18, 2024
@RivaIvanova
Copy link
Member

The Space key default behavior should be prevented in both activation modes.
If the mdoe is auto and I press Space on an active tab, the page is scrolled. This is not reproducible in WC.
igx-tabs

@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels Oct 18, 2024
@georgianastasov georgianastasov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 18, 2024
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 18, 2024
@RivaIvanova RivaIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 18, 2024
@kacheshmarova kacheshmarova merged commit f327f02 into master Oct 18, 2024
@kacheshmarova kacheshmarova deleted the ganastasov/feat-14839-master branch October 18, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keyboard-navigation tabs version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs: add manual activation through keyboard navigation

5 participants