Skip to content

Introducing percent type column#8988

Merged
zdrawku merged 15 commits intomasterfrom
ddincheva/percentTypeCol
Feb 16, 2021
Merged

Introducing percent type column#8988
zdrawku merged 15 commits intomasterfrom
ddincheva/percentTypeCol

Conversation

@ddincheva
Copy link
Contributor

@ddincheva ddincheva commented Feb 15, 2021

Closes #8331

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddincheva ddincheva added 🛠️ status: in-development Issues and PRs with active development on them grid: column-types version: 11.1.x labels Feb 15, 2021
@ddincheva ddincheva self-assigned this Feb 15, 2021
@zdrawku zdrawku self-requested a review February 16, 2021 08:46
@zdrawku zdrawku assigned zdrawku and ddincheva and unassigned ddincheva Feb 16, 2021
@ddincheva ddincheva added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 16, 2021
@ddincheva ddincheva removed their assignment Feb 16, 2021
@dobromirts dobromirts added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 16, 2021
@dobromirts dobromirts self-requested a review February 16, 2021 12:03
dobromirts
dobromirts reviewed Feb 16, 2021
View reviewed changes
@ddincheva @dobromirts
chore(*): update column percentage sample
8124793 
Co-authored-by: dobromirts <46093564+dobromirts@users.noreply.github.com>
@dobromirts dobromirts added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Feb 16, 2021
@zdrawku zdrawku merged commit 9d2eb00 into master Feb 16, 2021
@zdrawku zdrawku deleted the ddincheva/percentTypeCol branch February 16, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdrawku zdrawku zdrawku approved these changes

@dobromirts dobromirts dobromirts approved these changes

Assignees

@zdrawku zdrawku

@ddincheva ddincheva

Labels

grid: column-types version: 11.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Currency and Percent type of a Column

3 participants

@ddincheva @zdrawku @dobromirts