chore: update wc, react and dock-manager#1321
Merged
jackofdiamond5 merged 3 commits intomasterfrom Oct 11, 2024
Merged
Conversation
valadzhov
previously approved these changes
Oct 4, 2024
jackofdiamond5
added
💥 status: in-test
🛠️ status: in-development
and removed
❌ status: awaiting-test
💥 status: in-test
labels
jackofdiamond5
requested changes
Oct 4, 2024
Member
There was a problem hiding this comment.
For WC I get
This is because the igc-form component has been removed in IgniteUI/igniteui-webcomponents#1281, IgniteUI/igniteui-webcomponents#1302 so we need to use the native form in our templates.
jackofdiamond5
approved these changes
Oct 11, 2024
Member
jackofdiamond5
left a comment
jackofdiamond5
left a comment
There was a problem hiding this comment.
I found a little problem with the radio group, where you can select more than one option. But this is not necessarily related to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update old references in the templates