Skip to content

Add information regarding resizing columns in percentages and remove obsolete one.#2045

Merged
ChronosSF merged 8 commits intovNextfrom
skrastev/resize-percents
Jul 1, 2020
Merged

Add information regarding resizing columns in percentages and remove obsolete one.#2045
ChronosSF merged 8 commits intovNextfrom
skrastev/resize-percents

Conversation

@skrustev
Copy link
Member

Checklist:

  • check topic's TOC/menu and paragraph headings
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

@ChronosSF ChronosSF requested a review from MayaKirova June 29, 2020 13:23
@ChronosSF ChronosSF self-requested a review June 30, 2020 07:47
ChronosSF
ChronosSF previously approved these changes Jun 30, 2020

**Percentages**

Resizing column with widths in percentages, the horizontal amount of the mouse movement in pixels is translated roughly to its percentage amount relative to the grid width. This means that a column may appear to snap to a certain size when resizing ends. Percentages sizes are only integers and there are usually some pixels lost when sizing a column in this way.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer accurate - 'Percentages sizes are only integers and there are usually some pixels lost when sizing a column in this way.' As of the latest changes the percentages are floats to increase the resizing accuracy. Some difference between the % and pixel values is still possible.

@ChronosSF ChronosSF merged commit 5934744 into vNext Jul 1, 2020
@ChronosSF ChronosSF deleted the skrastev/resize-percents branch July 1, 2020 14:13
DenitsaHristova added a commit that referenced this pull request Jul 7, 2020
zdrawku added a commit that referenced this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants