Add information regarding resizing columns in percentages and remove obsolete one.#2045
Merged
Add information regarding resizing columns in percentages and remove obsolete one.#2045
Conversation
ChronosSF
requested changes
Jun 29, 2020
ChronosSF
previously approved these changes
Jun 30, 2020
4 tasks
MayaKirova
requested changes
Jul 1, 2020
|
|
||
| **Percentages** | ||
|
|
||
| Resizing column with widths in percentages, the horizontal amount of the mouse movement in pixels is translated roughly to its percentage amount relative to the grid width. This means that a column may appear to snap to a certain size when resizing ends. Percentages sizes are only integers and there are usually some pixels lost when sizing a column in this way. |
Contributor
There was a problem hiding this comment.
This is no longer accurate - 'Percentages sizes are only integers and there are usually some pixels lost when sizing a column in this way.' As of the latest changes the percentages are floats to increase the resizing accuracy. Some difference between the % and pixel values is still possible.
ChronosSF
approved these changes
Jul 1, 2020
MayaKirova
approved these changes
Jul 1, 2020
DenitsaHristova
added a commit
that referenced
this pull request
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
../relative/path.mdIgxSelectComponent,<igx-combo>code blocksfor the names of classes / tags / propertiescode blockspending-localizationlabel when the review of the PR is done