Merged
Conversation
rkaraivanov
reviewed
Jun 6, 2024
Member
rkaraivanov
left a comment
rkaraivanov
left a comment
There was a problem hiding this comment.
Minor comments otherwise LGTM.
However, can you fix both the CI and the storybook builds as of now I cannot really "play" with the component?
|
Material, Fluent and Bootstrap Paddings are fine -> 8px (left and right) to the igx-banner, 8px (left and right) to the igx-banner _message and 16px top and bottom. |
…gh the illustration part
…UI/igniteui-webcomponents into rivanova/feat-banner-1174
rkaraivanov
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1174