Conversation
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
* Masked value with focus/blur/drag
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
…onents into rkaraivanov/masked-input
* Handle valid/invalid states * More unit tests
damyanpetev
reviewed
Apr 11, 2022
…onents into rkaraivanov/masked-input
damyanpetev
reviewed
Apr 13, 2022
Member
There was a problem hiding this comment.
The spec mentionsNvm this works, just not as I expected in Storybook and had to refresh the entire pageset an autofocus attribute so that the field can become focused on initial page loadbut it doesn't work- When an empty input is
readonlyfocusing it still brings up the mask with prompts, which I think shouldn't happen as it suggest it can be edited - With the default mask if you fill some end portion (i.e. skip a few start positions) when you focus back the input the value shifts to the start. Bit edge, but still landed on it
- The input event is fired when deleting over literals that in a mask does nothing, but I'll chuck that under a minor gripe and can be left as is
damyanpetev
reviewed
Apr 18, 2022
damyanpetev
approved these changes
Apr 19, 2022
simeonoff
approved these changes
Apr 20, 2022
ChronosSF
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173