Merged
Conversation
…eui-webcomponents into ibarakov/feat-247
# Conflicts: # src/components/input/input-base.ts
# Conflicts: # src/components/common/definitions/defineAllComponents.ts # src/components/input/input-base.ts # src/index.ts
# Conflicts: # src/components/common/definitions/defineAllComponents.ts
rkaraivanov
requested changes
Jun 7, 2022
src/index.ts
Outdated
| export { IgcSliderBaseComponent } from './components/slider/slider-base.js'; | ||
| export { IgcButtonBaseComponent } from './components/button/button-base.js'; | ||
| export { IgcCalendarBaseComponent } from './components/calendar/common/calendar-base.js'; | ||
| export { IgcMaskInputBaseComponent } from './components/mask-input/mask-input-base.js'; |
Member
There was a problem hiding this comment.
👍
Don't export it.
I would vouch to remove the export of the other base classes as well in the future.
# Conflicts: # src/components/mask-input/mask-input.ts
ChronosSF
added
💥 status: in-test
✅ status: verified
and removed
✅ status: verified
💥 status: in-test
labels
ChronosSF
previously approved these changes
Jul 1, 2022
damyanpetev
previously approved these changes
Jul 1, 2022
rkaraivanov
requested changes
Jul 1, 2022
Member
rkaraivanov
left a comment
rkaraivanov
left a comment
There was a problem hiding this comment.
LGTM
Just fix the import path and it is good to go.
ChronosSF
approved these changes
Jul 1, 2022
rkaraivanov
approved these changes
Jul 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #247