Merged
Conversation
…eUI/igniteui-webcomponents into mtsvyatkova/tabs-component
rkaraivanov
requested changes
May 16, 2022
simeonoff
requested changes
May 17, 2022
Collaborator
simeonoff
left a comment
simeonoff
left a comment
There was a problem hiding this comment.
I can see a slight border leftover in the selected tab when using bootstrap.
Comment on lines
+24
to
+30
| > * { | ||
| margin-inline-start: rem(12px); | ||
|
|
||
| &:first-child { | ||
| margin-inline-start: 0; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
We can replace all this with:
Suggested change
| > * { | |
| margin-inline-start: rem(12px); | |
| &:first-child { | |
| margin-inline-start: 0; | |
| } | |
| } | |
| gap: rem(12px); |
Comment on lines
+72
to
+73
| width: rem(24px); | ||
| height: rem(24px); |
Collaborator
There was a problem hiding this comment.
Use --size for sizing igc-icons.
simeonoff
previously approved these changes
Jun 27, 2022
simeonoff
previously approved these changes
Jun 27, 2022
Support using tab as a tab strip Support selection through attribute for tab children. Mutation observer to sync DOM changes for ARIA and selection states. Some fixed issues.
simeonoff
previously approved these changes
Jul 5, 2022
damyanpetev
previously approved these changes
Jul 5, 2022
rkaraivanov
previously approved these changes
Jul 6, 2022
Member
|
@rkaraivanov I've noticed on the Strip sample since they have no panels the change event emits empty string detail for all - perhaps we should consider adding the entire tab element to the detail? Also an idea related to that - perhaps we can add functionality to auto-associate tabs and panels based on index so explicit ids are not mandatory (will ease generating tabs from designs) |
rkaraivanov
dismissed stale reviews from damyanpetev, simeonoff, and themself
via
b40785d
damyanpetev
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185