Conversation
rkaraivanov
force-pushed
the
rkaraivanov/textarea
branch
from
8d0f6d6 to
4f7bac5
Compare
…onents into rkaraivanov/textarea
…niteui-webcomponents into rkaraivanov/textarea
…onents into rkaraivanov/textarea
…onents into rkaraivanov/textarea
…niteui-webcomponents into rkaraivanov/textarea
…onents into rkaraivanov/textarea
Member
Author
|
I thought that sizing was done through CSS variables in new components. Can you remove the SizableMixin and style it based on the CSS variable? |
SisIvanova
reviewed
Jun 28, 2023
…onents into rkaraivanov/textarea
simeonoff
requested changes
Oct 2, 2023
Collaborator
simeonoff
left a comment
simeonoff
left a comment
There was a problem hiding this comment.
The styles need some minor changes.
Collaborator
|
@desig9stein can you validate the implemented component against angular for differences? |
Contributor
|
@SisIvanova I spotted a few things.
|
simeonoff
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #764