Conversation
Closed
5 tasks
RivaIvanova
force-pushed
the
button-group/feat-827
branch
from
a7a5a8b to
06e9fca
Compare
rkaraivanov
requested changes
Aug 31, 2023
Member
rkaraivanov
left a comment
rkaraivanov
left a comment
There was a problem hiding this comment.
I'm currently re-working the specifications into a single unified spec.
Since there are some more issues to address for the group, I'll do the review after the specification is "finalized".
…onents into button-group/feat-827
…gniteui-webcomponents into button-group/feat-827
…onents into button-group/feat-827
…gniteui-webcomponents into button-group/feat-827
…gniteui-webcomponents into button-group/feat-827
rkaraivanov
requested changes
Sep 18, 2023
Collaborator
|
@desig9stein The material button group doesn't look like the one in Ignite UI for Angular. |
…size as well as the whole group. fix icon size, make sure that igx icon inside igc-button-group is handled correctly
simeonoff
requested changes
Sep 27, 2023
| $material: map.merge( | ||
| digest-schema($dark-button-group), | ||
| ( | ||
| border-radius: border-radius(map.get($dark-button-group, 'border-radius')...), |
Collaborator
There was a problem hiding this comment.
@desig9stein You no longer need to resolve the border radius like that. It's already been resolved when digesting the schema.
rkaraivanov
approved these changes
Sep 28, 2023
Member
|
Can you verify the visual design of this PR? |
ddaribo
added
💥 status: in-test
✅ status: verified
and removed
❌ status: awaiting-test
💥 status: in-test
labels
simeonoff
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #827 #877