Skip to content

Draft manifest files#99

Open
davidorme wants to merge 5 commits intomainfrom
98-add-draft-manifestyaml-files
Open

Draft manifest files#99
davidorme wants to merge 5 commits intomainfrom
98-add-draft-manifestyaml-files

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

This PR just adds draft manifest files to the data directories.

@davidorme davidorme linked an issue Aug 6, 2025 that may be closed by this pull request
@davidorme davidorme requested a review from annarallings August 6, 2025 16:48
script: null
url: null
- md5: null
name: morbilliviruses.fasta
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this file was used as an example in one of the tutorial sessions (think it's also only found on your local machine). Should it be removed?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should - there are a couple of other ones too.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - I have deleted three dummy files (morbilliviruses.fasta, data.csv, more_data.csv) from GLOBUS and updated the MANIFEST files.

@davidorme
Copy link
Copy Markdown
Collaborator Author

@arne-exe We have a number of CSV files that have been committed to the repo:

> git ls-files | grep .csv
data/derived/plant/plant_functional_type/plant_functional_type_cohort_distribution.csv
data/derived/plant/plant_functional_type/plant_functional_type_cohort_distribution_per_hectare.csv
data/derived/plant/plant_functional_type/plant_functional_type_species_classification_base.csv
data/derived/plant/plant_functional_type/plant_functional_type_species_classification_maximum_height.csv
data/derived/plant/reproductive_tissue_allocation/reproductive_tissue_allocation.csv
data/derived/plant/traits_data/plant_stoichiometry.csv
data/derived/plant/traits_data/t_model_parameters.csv

Those are all now on GLOBUS, so I am removing them from the repo in this PR.

Up to date:
 - derived/plant/plant_functional_type/plant_functional_type_cohort_distribution.csv
 - derived/plant/plant_functional_type/plant_functional_type_cohort_distribution_per_hectare.csv
 - derived/plant/plant_functional_type/plant_functional_type_species_classification_base.csv
 - derived/plant/plant_functional_type/plant_functional_type_species_classification_maximum_height.csv
 - derived/plant/reproductive_tissue_allocation/reproductive_tissue_allocation.csv
 - derived/plant/traits_data/plant_stoichiometry.csv
 - derived/plant/traits_data/t_model_parameters.csv

@arne-exe
Copy link
Copy Markdown
Collaborator

arne-exe commented Aug 7, 2025

@arne-exe We have a number of CSV files that have been committed to the repo:
Those are all now on GLOBUS, so I am removing them from the repo in this PR.

Ok, the cohort distribution file has changes that have not been merged yet, I'm unsure if this will cause issues?
Or should I just copy paste the updated file from the data folder on the new branch to main?

@davidorme
Copy link
Copy Markdown
Collaborator Author

Ok, the cohort distribution file has changes that have not been merged yet, I'm unsure if this will cause issues?
Or should I just copy paste the updated file from the data folder on the new branch to main?

It is moving out of being handled by git, so upload it to GLOBUS instead.

Caution

Note that when this PR gets merged into main and you then pull it, these data files will be removed, because git has been told to stop tracking them. So you will need to replace them from GLOBUS (or you could just make a local copy and replace them from there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add draft MANIFEST.yaml files.

3 participants